Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obsreport: wire up ReceiverCreateSettings for scrapers using obsreport #4150

Closed

Conversation

Aneurysm9
Copy link
Member

Signed-off-by: Anthony J Mirabella a9@aneurysm9.com

Link to tracking Issue: #3922

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@Aneurysm9 Aneurysm9 requested review from a team and owais September 29, 2021 23:11
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #4150 (2274289) into main (896335f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4150      +/-   ##
==========================================
+ Coverage   87.66%   87.71%   +0.04%     
==========================================
  Files         174      174              
  Lines       10224    10233       +9     
==========================================
+ Hits         8963     8976      +13     
+ Misses       1011     1007       -4     
  Partials      250      250              
Impacted Files Coverage Δ
config/configtest/configtest.go 96.66% <100.00%> (ø)
obsreport/obsreport_scraper.go 100.00% <100.00%> (ø)
receiver/scraperhelper/scraper.go 100.00% <100.00%> (ø)
receiver/scraperhelper/scrapercontroller.go 93.10% <100.00%> (+0.08%) ⬆️
obsreport/obsreporttest/obsreporttest.go 64.74% <0.00%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69935d8...2274289. Read the comment docs.

@Aneurysm9
Copy link
Member Author

Folding into #4149 as there is too much overlap.

@Aneurysm9 Aneurysm9 closed this Sep 29, 2021
@Aneurysm9 Aneurysm9 deleted the obsreport_settings_scraper branch September 29, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant